Wrong table name when using abstract models

Hello people,

What’s the expected table name for a history model when I’m using an abstract model like this?

# core/models.py
class HistoryMixin(models.Model):
    history = HistoricalRecords(inherit=True)
    class Meta:
        abstract = True

class SameModuleModel(HistoryMixin, models.Model):
    pass

# app1/models.py
class AnotherAppModel(HistoryMixin, models.Model):
    pass

In this example, the makemigrations output is:

Migrations for 'core':
  0001_initial.py:
    - Create model HistoricalAnotherAppModel
    - Create model HistoricalSameModuleModel
    - Create model SameModuleModel
Migrations for 'app1':
  0001_initial.py:
    - Create model AnotherAppModel

All models that inherit from HistoryMixin will have its history db table named like core_historicalmodel_name and not like model_module_using_HistoryMixin_historicalmodel_name.

Am I not seeing something here?

Thanks.

[rossmechanic]

This issue is fixed in #324 with tests

[macro1]

@rougeth: This looks like an edge case that was missed when the feature was added. I’ll look at patching it.

Several people asked for the feature, so even though I don’t use it myself I put some code together that would make it work, and asked for testing in addition to the unit tests I added, but I guess it was missed.

Hopefully having the table names changed won’t cause too many issues for people already using the feature.