DocCommentId incorrect for a nested type of a generic class

Originating bug report on the .net core API docs: https://github.com/dotnet/dotnet-api-docs/issues/2854

To summarize, we start with this method signature:

public static ImmutableArray<TSource> ToImmutableArray<TSource>(this ImmutableArray<TSource>.Builder builder)

Compiler output is

M:System.Collections.Immutable.ImmutableArray.ToImmutableArray``1(System.Collections.Immutable.ImmutableArray{``0}.Builder)

and DocCommentId output is

M:System.Collections.Immutable.ImmutableArray.ToImmutableArray``1(System.Collections.Immutable.ImmutableArray`1.Builder{``0})

I verified it with the following minimal example:

public class Test<T> {
	public class Builder {}

	public static Test<T> ToTest (Test<T>.Builder b) => new Test<T> ();
}

which gives the following result

M:Mono.Cecil.Tests.Test`1.ToTest(Mono.Cecil.Tests.Test`1.Builder{`0})

Simple test case was written against the cecil master branch in the unit test project …

[joelmartinez]

@jbevain I will if it’s not resolved by the time the original issue gets prioritized onto my plate ( 😉 @mimisasouvanh). Not 100% sure when that will be, but I’ll definitely need to resolve that at some point in the future … so I’m definitely up for working on it at that point.

[joelmartinez]

lol, yeah … I’ll make sure to include a number of tests and scenarios once it’s implemented (while also double checking against the roslyn results). I don’t know exactly when I’ll finish this, but I’ll have a PR for you at some point 😃