Can one client connection be used for the lifetime of an app?

Since as of version 3.0.0 per https://github.com/jbielick/faktory_worker_node/blob/master/CHANGELOG.md#300--2019-02-11, a connection pool is added to each client, is it advantageous/recommended to instantiate a single client connection to be used for the lifetime of an app?

Also, can you clarify what is meant by (taken from the changelog):

Client.connect() not necessary before using connection Client.connect() now connects and disconnects to test the connection details. A connection is created in the pool when it is needed.

[jbielick]

Does this make sense? And I don’t need to close the client manually?

Absolutely! And as for closing: I would try and do so, but it’s not typically critical.

SIGINT or whatever signal you’re sending typically terminates those connections, but it can be helpful to await client.close() to shut down the connection pool gracefully. I wouldn’t worry too much about it unless you’re having issues.

Also—you may have omitted some small details for brevity, so forgive me if these are already known. faktory.connect() is async, so you’ll want to await that before starting your server. This ensures the connection is possible and ready before starting your app (helpful when it comes to health checks). I’d recommend adding the client to the request object in a middleware so it’s available to all HTTP handlers instead of relying on the closure having access to the client var. It would look something like this:

import faktory from 'faktory-worker';
import express from 'express';

const app = express();

router.get('/some-path', async (req, res, next) {
  // ... do some work
  await req.faktory.job(...).push();
  await req.faktory.job(...).push();
  next();
});

(async () => {
  const client = await faktory.connect();
  
  app.use(async (req, res, next) => {
    req.faktory = client;
    next();
  });  

  app.listen(...);
}).catch(console.error.bind(console));

But again, if you don’t have any issues you’re probably fine. Feel free to disregard.

[CaryLandholt]

Excellent! Yep, was going to use express middleware just like your code snippet. Thanks again!