error when running some inquiries

Hi, first thank you very much for this software. I have tis inverter: https://www.amazon.de/dp/B07YL3VVQ2/ref=pe_3044161_185740101_TE_item and running mpp-solar version: 0.7.41 Atm I only use -c QPIGS and send the output via MQTT to ioBroker, so this is nothing I need here, just wanted to let you know.

I have a problem when running command different Qxxx commands, resulting in a traceback. This happens for: QBOOT, QOPM, QPGS, QPIRI, The outputs with the first 3 commands are (replace <command> by the command without Q:

Traceback (most recent call last):
  File "/usr/local/bin/mpp-solar", line 11, in <module>
    load_entry_point('mpp-solar', 'console_scripts', 'mpp-solar')()
  File "/root/src/mpp-solar/mppsolar/__init__.py", line 387, in main
    results = _device.run_command(command=_command)
  File "/root/src/mpp-solar/mppsolar/devices/device.py", line 309, in run_command
    decoded_response = self._protocol.decode(raw_response, command)
  File "/root/src/mpp-solar/mppsolar/protocols/abstractprotocol.py", line 263, in decode
    msgs[key] = [resp_format[2][int(result)], ""]
ValueError: invalid literal for int() with base 10: '<command>'

The output for QPIRI is:

Traceback (most recent call last):
  File "/usr/local/bin/mpp-solar", line 11, in <module>
    load_entry_point('mpp-solar', 'console_scripts', 'mpp-solar')()
  File "/root/src/mpp-solar/mppsolar/__init__.py", line 387, in main
    results = _device.run_command(command=_command)
  File "/root/src/mpp-solar/mppsolar/devices/device.py", line 309, in run_command
    decoded_response = self._protocol.decode(raw_response, command)
  File "/root/src/mpp-solar/mppsolar/protocols/abstractprotocol.py", line 254, in decode
    msgs[key] = [int(result), resp_format[2]]
ValueError: invalid literal for int() with base 10: '-'

Greetings from Rhein-Main-Area, Germany Jörg

[jblance]

QOPM isnt working for you (it also doesnt return a valid result on my system), but the validity check only looks at the crc and the result is the same as the command for some reason, so it tests as valid QPIRI is failng as it was expecting a number and is getting a - I have made some changes that should fix this bug in version 0.7.42 The QPIRI command does give an answer to what QOPM should return - it looks like QOPM isnt supported on all models (mine included)

QPIRI result from your debug:

Command: QPIRI - Current Settings inquiry
------------------------------------------------------------
Parameter                     	Value           Unit
ac_input_voltage              	230.0          	V   
ac_input_current              	13.0           	A   
ac_output_voltage             	230.0          	V   
ac_output_frequency           	50.0           	Hz  
ac_output_current             	13.0           	A   
ac_output_apparent_power      	3000           	VA  
ac_output_active_power        	2400           	W   
battery_voltage               	24.0           	V   
battery_recharge_voltage      	23.0           	V   
battery_under_voltage         	21.0           	V   
battery_bulk_charge_voltage   	28.2           	V   
battery_float_charge_voltage  	27.0           	V   
battery_type                  	AGM            	    
max_ac_charging_current       	30             	A   
max_charging_current          	50             	A   
input_voltage_range           	Appliance      	    
output_source_priority        	SBU first      	    
charger_source_priority       	Solar first    	    
max_parallel_units            	-              	units
machine_type                  	Off Grid       	    
topology                      	transformer    	    
output_mode                   	single machine output	    
battery_redischarge_voltage   	26.0           	V   
pv_ok_condition               	As long as one unit of inverters has connect PV, parallel system will consider PV OK	    
pv_power_balance              	PV input max current will be the max charged current	    

Thanks again for the feedback and diagnosis

[jblance]

I have created new issues for the problems above, will close this and track changes in #88 and #89