Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Update ws dependency to 1.x

See original GitHub issue

When I try to run heavy loads (many queries consecutively or concurrently) using this library with node 6.6.0, I occasionally run into issues like this one that appear to come from the underlying websockets library. When I shrinkwrap and bump the version of ws up from 0.8.0 to 1.1.1 everything still appears to work for me and the intermittent errors go away.

Is there a reason to stay on ws 0.x or can it be bumped to 1.x? It would be nice to not have to force the version up with shrinkwrap.

I can also try pulling the repo, updating and testing with the new version of ws when I have some time. I assume this is what i need to run:

npm run build
npm run test:node

Issue Analytics

State:
Created 7 years ago
Reactions:1
Comments:6 (6 by maintainers)

Top GitHub Comments

2reactions

jbmussocommented, Sep 29, 2016

There is no specific reason to stick to ws@v0.8.0. I’ll try to bump the version in the coming days. If you could send a pull request instead, that would be really cool 😃.

Just curious, how many concurrent requests are you executing (even approximately)?

0reactions

princjefcommented, Mar 31, 2017

fixed by #74