Expose additional directory entry fields

The smbclient.scandir function returns an iterator to SMBDirEntry objects – and since the directory is queried for FILE_ID_FULL_DIRECTORY_INFORMATION, the internal _dir_info structure holds additional useful information such as allocation_size and last_write_time.

These should be exposed the same way that inode() is exposing the file_id field.

[jborean93]

Just as an FYI this is somewhat possible today through public interfaces

import smbclient

from smbprotocol.file_info import FileInformationClass

path = r'\\server\share\dir'

with smbclient.open_file(path, mode='rb', buffering=0, file_type='dir', share_access='r') as dir:
    for dir_entry in dir.query_directory("*", FileInformationClass.FILE_NAMES_INFORMATION):
        print(dir_entry['file_name'].get_value().decode('utf-16-le'))

This is essentially what scandir does except now you are just dealing with the raw information.

Unfortunately it does expose the raw structure value back which isn’t the easiest to deal with.

[malthe]

Perhaps a new function querydir which can then return a richer object that more closely models the file information class?

That is – we keep SMBDirEntry for the result of scandir but introduce a new class for the result of querydir that explicitly exposes FileInformationClass.FILE_ID_FULL_DIRECTORY_INFORMATION (or whatever information class is requested).

This might then also be an opportunity to dial down the information class for scandir – presumably it costs a little extra on the server side to retrieve all that metadata.