Rebuild on Windows fails with missing "deps" directory

Hi there,

I’m trying to build the lib on Windows. However, when installed via NPM, the node-libcurl/deps directory seems to be missing (I see that it’s in .npmignore).

This causes npm install node-libcurl --build-from-source to fail with the following error:

C:\Users\IEUser\Desktop\insomnia>npm install node-libcurl --build-from-source

> node-libcurl@1.0.0 install C:\Users\IEUser\Desktop\insomnia\node_modules\node-libcurl
> node-pre-gyp install --fallback-to-build

File:  C:\Users\IEUser\Desktop\insomnia\node_modules\node-libcurl\deps\curl-for-windows\libssh2.gyp  not found.
gyp: Call to 'node "C:\Users\IEUser\Desktop\insomnia\node_modules\node-libcurl/tools/retrieve-win-deps.js"' returned exit status 1 while in binding.gyp. while trying to load binding.gyp

Is there a way to get around this missing dependency?

Note: it works fine without --build-from-source (using the prebuilt bins), but I need to be able to rebuild it for use with Electron.

[gschier]

Just letting you know that the new version now works as expected.

[JCMais]

After some debugging, it looks like the check being used to see if you’re in a git repo returns a false positive if the parent directory is a git repo

You are right! I didn’t think of that. I could parse the result of git rev-parse --git-dir or git rev-parse --show-toplevel and make sure it’s the same directory of the module.