Investigate errors in SQLAlchemy 1.3

After bringing in #6, we’ve had reports of unreliability with some tests:

@charness thank you for the fix, I couldn’t trace this down for a long time!

However, it introduced some flakiness in our test suite for several tests that do a commit and then check if the attribute changes. Have you had anything like it?

The code is similar to this:

def test_should_confirm_account(db_session, app_client):
    user = UserFactory()
    token = user.generate_token_and_save_timestamp()

    db_session.add(user)
    # First commit or flush in some cases
    db_session.commit()

    # One more commit here:
    response = app_client.post("/account/confirm", json={"token": token})
    assert response.status_code == 200

    # Fails with:
    # Instance <User at 0x108bf1d30> is not bound to a Session; attribute refresh operation cannot proceed (Background on this error at: http://sqlalche.me/e/bhk3 
    assert user.is_confirmed()

Check to see if this example can be reproduced, and if so, investigate the root cause of the problem.

Edit 3/12: This appears to be a problem with SQLAlchemy 1.3. Pinning your SQLAlchemy version to <1.3 should fix any errors in the meantime while we figure out what exactly is going on.

[jeancochrane]

Just published v1.0.2 providing support for SQLAlchemy 1.3. Thanks for the help figuring this out, all!

[killthekitten]

@jeancochrane you’re amazing!