Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Ability to index documents incrementally

See original GitHub issue

This patch provides the ability to add documents incrementally by using a new add method in conjunction with an identifyItem function. It does this by keeping track of the item ids in the indexmap dictionary where the values are the position into the index of where the item lives.

0001-Provide-the-ability-to-incrementally-add-to-the-inde.patch.zip

Additionally, this patch moves grunt into devDependencies instead of as a dependency.

0002-Make-grunt-a-devDependency.patch.zip

Issue Analytics

State:
Created 6 years ago
Comments:8 (8 by maintainers)

Top GitHub Comments

2reactions

jeancroycommented, Jul 21, 2017

Hi @mrkishi thanks for your report !

I think it is now fixed. We preallocated the array in _prepSource but then pushed to the end of the array in add. So the whole preallocated space is undefined, which cause error when reading in loop

I’ve added a counter for item that are actually in use.

0reactions

mrkishicommented, Jul 21, 2017

That was way too fast, thanks! 💯

Took me days to notice it in the first place (since we don’t usually update git-based dependencies).

In any case, it’s on me for not pinning on a specific commit.