onCreateOption is not called, fails at `valueArray[valueArray.length - 1] === newOption`

Getting a weird bug at this line.

https://github.com/JedWatson/react-select/blob/c8d74bd5710b1db6736837fb4334a59e46614a27/packages/react-select/src/Creatable.js#L148

It seems that the === comparison fails on this line.

valueArray[valueArray.length - 1] === newOption

I put debugger breakpoint and inspected the values. Please see the console output.

> valueArray[valueArray.length - 1] === newOption
false
> newOption === newValue 
false
> newOption
{label: "Create "sd"", value: "sd", __isNew__: true}
> newValue
{label: "Create "sd"", value: "sd", __isNew__: true}
> valueArray
[{…}]0: {label: "Create "sd"", value: "sd", __isNew__: true}length: 1__proto__: Array(0)
> valueArray.length
1

It looks like the newOption and newValue have the same content by they fail when compared using === operator. As the result the onCreateOption is not called.

[hamfz]

For anyone struggling with this in the interim, you can use the getNewOptionData prop to bust the equality check and properly pass through to onCreateOption.

Ex:

getNewOptionData={(inputValue, optionLabel) => ({
     value: inputValue,
     label: optionLabel,
     __isNew__: true,
     isEqual: () => false
  })
}

[nikitaindik]

@gwyneplaine Please check out the fix and tell me what you think. I’ve ran the tests and did some manual testing on the docs page - everything seems to be fine. I’d be happy to add a test, but I’ll need a little guidance.