[v2] with openMenuOnClick: false and openMenuOnFocus: false, menu still toggles on click

continuing to stuggle with the upgrade, and seeing this.

We’re using react-select to show results for typeahead search, so I only ever want the menu to be showing when there are results to list. I tried setting both openMenuOnClick and openMenuOnFocus to false, but the menu continues to come up (with no results) when clicking inside of the input.

I expect the menu to never, ever show up when the user clicks in the input, or any parts of the input when these settings are set to false.

[Korkemoms]

I copied the below function from ReactSelect’s souce code and modified (1) and (2) below. Then using ref I replace the function with my modified one.

<ReactSelect ref={node => {
    if (node) {
      const select = node.select;
      select.onControlMouseDown = event => {
        const { openMenuOnClick } = select.props;
        if (!select.state.isFocused) {
          if (openMenuOnClick) {
            select.openAfterFocus = true;
          }
          select.focusInput();
        } else if (!select.props.menuIsOpen) {

          // i added this if statement  (1)
          if (openMenuOnClick) {
            select.openMenu("first");
          }
          
           // i removed this statement (2)
          //select.openMenu("first");
        } else {
          select.onMenuClose();
        }
        if (event.target.tagName !== "INPUT") {
          event.preventDefault();
        }
      };
    }
  }} />

[rscotten]

@tpict

Here’s the PR using @Korkemoms’s fix: #3334