Flip_item is not applied during training
See original GitHub issueDear authors, thanks for the great work!
I noticed that parameter flip_item
passed into the model is set to None during train()
but is popped from is_flipped
key during validate_gt()
in validate_gt: https://github.com/Jeff-sjtu/HybrIK/blob/b8cfeeb7df2d7c8024865751cc17664a8272557b/scripts/train_smpl.py#L128-L130
When flip_item
is set toNone
, the phi, leaf, shapes and uvd_coordinates will not be flipped during training even though the image and keypoints3d might be flipped during augmentations.
https://github.com/Jeff-sjtu/HybrIK/blob/e10afb149e10cf721b619b12eb81f02b7ad3c4e0/hybrik/models/simple3dposeBaseSMPL24.py#L298-L325
I would also like to confirm if flip_item
is indeed set to None for all training? And if yes, why is flipping of phi, shapes and uvd_coord not applied during training, but applied during validation?
I am rather confused regarding this procedure, and hope to get some clarification on this. Thank you!
Issue Analytics
- State:
- Created 2 years ago
- Comments:7 (3 by maintainers)
Top GitHub Comments
Hi @pangyyyyy, I think the bug is fixed now!
That’s great! Thank you so much!