Jekyll url is not applied to the View button

Description:

Pressing the View button in the admin panel the URL is pointing to http://localhost:4000. But I’m behind a reverse proxy called Nginx.

Tell us a bit about yourself:

• Version of JekyllAdmin I’m using: 0.10.2
• Version of Jekyll I’m using: 4.1.1
• Version of NodeJS I’m using: v14.15.0
• Operating System <e.g. OS X, Windows>: Linux!
• Browser <e.g, Safari, Chrome>: Firefox!

Steps to reproduce:

1. Setup Jekyll as normal
2. Configure _config.yml file, and set url key to: url: "https://yourdomain.com" (baseurl is just “/”)
3. Configure Nginx to use yourdomain.com as server_name in Nginx with a location / section containing at least: proxy_pass http://localhost:4000;
4. Go to admin panel: https://yourdomain.com/admin
5. Press the View button
6. Links goes to http://localhost:4000/jekyll/update/2020/11/19/welcome-to-jekyll.html, which will NOT work.

I expected the following:

I expect the View links to take the url settings into account. The link example above, should go to:

https://yourdomain.nl/jekyll/update/2020/11/19/welcome-to-jekyll.html

But got the following, instead:

http://localhost:4000/jekyll/update/2020/11/19/welcome-to-jekyll.html

I think it shouldn’t be that hard to get this solved, I hope 👍🏽 ?

Regards, Melroy van den Berg

[i-a-n]

this has been brought up a few times I believe, and I have yet to see an official response. I was able to get this working on my personal fork, however I do not believe my method (hijacking the URLable library to look for a special Jekyll config param) is necessarily a good answer for this project.

you can see my personal hack at this commit:

lib/jekyll-admin/urlable.rb

    def scheme
      JekyllAdmin.site.config["static_scheme"] || "http"
    end

    def host
      JekyllAdmin.site.config["static_host"] || JekyllAdmin.site.config["host"].sub("127.0.0.1", "localhost")
    end

    def port
      JekyllAdmin.site.config["static_port"] || JekyllAdmin.site.config["port"]
    end

… then on my Jekyll install:

_config.yml

static_scheme: https
static_host: [my domain name]
static_port: "443"

this got things working for me 👍

[ashmaroli]

Would you approve this?

I would approve a tested Pull Request that proposes use of JekyllAdmin.site.config["jekyll_admin"][key] instead.