Configuration creates Cloud instances twice.

Your checklist for this issue

🚨 Please review the guidelines for contributing to this repository.

• Jenkins version 2.176.4

• Plugin version 1.35

• OS jenkins/jenkins:2.176.4 Docker image

Description

This issue relates to the MesosCloud plugin.

Given the following configuration.yaml

jenkins:
  agentProtocols:
    - "JNLP4-connect"
    - "Ping"
  numExecutors: 0
  clouds:
    - mesos:
        agentUser: "${JENKINS_AGENT_USER:-root}"
        frameworkName: "${JENKINS_FRAMEWORK_NAME:-Jenkins Scheduler}"
        jenkinsURL: "http://${JENKINS_FRAMEWORK_NAME:-jenkins}.${MARATHON_NAME:-marathon}.mesos:${PORT0:-8080}"
        mesosAgentSpecTemplates:
          - label: "linux"
            agentAttributes: ""
            agentCommandStyle: Linux
            containerInfo:
              dockerForcePullImage: false
              dockerImage: "mesosphere/jenkins-dind:0.8.0"
              dockerPrivilegedMode: true
              isDind: true
              networking: HOST
              type: "DOCKER"
            cpus: "0.1"
            disk: "0.0"
            domainFilterModel: "home"
            idleTerminationMinutes: 3
            jnlpArgs: "-noReconnect"
            maxExecutors: 1
            mem: "512"
            minExecutors: 1
            mode: EXCLUSIVE 
          - label: "windows"
            agentAttributes: "os:windows"
            agentCommandStyle: Windows
            containerInfo:
              dockerForcePullImage: false
              dockerImage: "mesosphere/jenkins-windows-node:latest"
              dockerPrivilegedMode: false
              isDind: false
              networking: BRIDGE
              type: "DOCKER"
            cpus: "1.0"
            disk: "0.0"
            domainFilterModel: "any"
            idleTerminationMinutes: 3
            jnlpArgs: "-noReconnect"
            maxExecutors: 1
            mem: "4096"
            minExecutors: 1
            mode: EXCLUSIVE 
        mesosMasterUrl: "${JENKINS_MESOS_MASTER:-http://leader.mesos:5050}"
        role: "${JENKINS_AGENT_ROLE:-*}"
unclassified:
  location:
    adminAddress: "address not configured yet <nobody@nowhere>"
    url: "http://jenkins.marathon.mesos:${PORT0:-8080}/"

When I build and start the docker container with

docker build -t mesosphere/jenkins:unstable .
docker run -e JENKINS_AGENT_USER=kjeschkies -e JENKINS_AGENT_ROLE=foo \
    -e JENKINS_FRAMEWORK_NAME=jenkins \
    -e JENKINS_CONTEXT=f -e PORT0=8080 \
    -e JENKINS_MESOS_MASTER="http://127.0.0.1:5050" \
    -e PORT1=7070 \
    mesosphere/jenkins:unstable

I see two instances of the MesosCloud class:

INFO: Augmented all extensions
May 15, 2020 3:58:47 PM org.jenkinsci.plugins.mesos.MesosCloud <init>
INFO: Created Mesos cloud instance for framework 28a354b3-d435-4c27-973d-abd474f21951 and endpoint http://127.0.0.1:5050                <------ HERE
May 15, 2020 3:58:49 PM akka.event.slf4j.Slf4jLogger$$anonfun$receive$1 applyOrElse
INFO: Slf4jLogger started
May 15, 2020 3:58:49 PM org.jenkinsci.plugins.mesos.MesosApi <init>
INFO: Starting USI scheduler flow.
May 15, 2020 3:58:50 PM org.jenkinsci.plugins.mesos.MesosApi getInstance
INFO: Initialized Mesos API object for framework 28a354b3-d435-4c27-973d-abd474f21951
May 15, 2020 3:58:51 PM com.mesosphere.mesos.client.MesosClient$ com$mesosphere$mesos$client$MesosClient$$mesosHttpConnection
INFO: Connecting to Mesos master http://127.0.0.1:5050
May 15, 2020 3:58:51 PM org.jenkinsci.plugins.mesos.MesosCloud <init>
INFO: Created Mesos cloud instance for framework 467fe63d-1c4e-43a2-8bde-7b26a63e4331 and endpoint http://127.0.0.1:5050                <------ HERE
May 15, 2020 3:58:51 PM akka.event.slf4j.Slf4jLogger$$anonfun$receive$1 applyOrElse
INFO: Slf4jLogger started
May 15, 2020 3:58:51 PM org.jenkinsci.plugins.mesos.MesosApi <init>
INFO: Starting USI scheduler flow.
May 15, 2020 3:58:51 PM org.jenkinsci.plugins.mesos.MesosApi getInstance
INFO: Initialized Mesos API object for framework 467fe63d-1c4e-43a2-8bde-7b26a63e4331
May 15, 2020 3:58:51 PM com.mesosphere.mesos.client.MesosClient$ com$mesosphere$mesos$client$MesosClient$$mesosHttpConnection
INFO: Connecting to Mesos master http://127.0.0.1:5050

[timja]

I have an unfinished PoC for it

What’s left to make it happen? I am happy to help. The Mesos Cloud plugin could benefit from such an help page as well.

time and interest that others would be interested in it.

I think our docs could live on Jenkins.io? 🤔

not sure if plugin specific docs should live there, I’m very much in favour of docs living with the code so that they stay in sync when changed

[timja]

What do you think about a simple Github pages for this?

I have an unfinished PoC for it: https://jenkins-configuration-as-code.netlify.app/docs/configuration-reload/