Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Label changes in GitHub are ignored after a PR has been opened

See original GitHub issue

The recently added label whitelist/blacklist feature has an annoying bug: if you whitelist a label but forget to add that label when you first open the PR, adding the label later and commenting “test this please” still doesn’t trigger the PR builder. The log contains entries like this

Mar 20, 2017 5:46:02 PM org.jenkinsci.plugins.ghprb.GhprbPullRequest checkWhiteListLabels
INFO: Can't find any of whitelist label.

even though the whitelist label is now set on the PR in question. The only fix appears to be to close and reopen the PR with the label in place to begin with.

This was also noted at https://github.com/jenkinsci/ghprb-plugin/pull/449#issuecomment-273789412

Issue Analytics

State:
Created 7 years ago
Reactions:13
Comments:10 (2 by maintainers)

Top GitHub Comments

9reactions

aali0730commented, Aug 19, 2021

Hi can we merge the fix for this? https://github.com/jenkinsci/ghprb-plugin/pull/804

Would be extremely useful if we can get this out.

8reactions

maxdanilovcommented, Mar 20, 2020

Hi @bjoernhaeuser , is there any movement on this issue? This PR has been suggested almost two years ago as a solution: https://github.com/jenkinsci/ghprb-plugin/pull/639 Any reason why it’s still not merged? It seems like a fundamental drawback in the plugin.