sha1 parameter not present in LTS jenkins 1.651.2 + ghprb 1.32.2, parametrized jobs

After upgrading to LTS 1.651.2 and latest stable version of ghprb plugin 1.32.2, I observe builds that have sha1 parameter undefined. Jobs were configured with DSL:

freeStyleJob('xxxx_pull-requests') {
  parameters {
    stringParam('sha1', null, null)
  }
    githubPullRequest {
      cron("${scm_poll_short}")
      useGitHubHooks()
    }
  }
...
}

Build was triggered, ghprb* variables were populated to environment, however, sha1 was not present. it can be seen here: https://ostroproject.org/jenkins/job/dsl-meta-ostro_pull-requests/1514/

After I removed stringParameter() from DSL, jobs started to be populating sha1 variable properly: https://ostroproject.org/jenkins/job/dsl-meta-ostro_pull-requests/1515/ , but that means it’s impossible to start those jobs manually anymore.

[dmaicher]

I might have the same issue today after upgrading to Jenkins 2.7 and plugin version 1.32.2. The environment variable ${ghprbSourceBranch} is suddenly empty… 😦

Could be connected?

[nickmshelley]

This is happening to us as well. We got it to run the correct PR by removing the sha1 parameter from our Jenkins job, but now all pending builds are combined into a single build and only the first one is run, so we get a job that looks like this (which will only run and comment on 2176):

GitHub pull request #2176 of commit db84c1fa12b075266382bda60be22eb6565a69ae, no merge conflicts.
GitHub pull request #2175 of commit 74ba2a1b47ccf2cbc2fb34d6226f2a72b93bee65, no merge conflicts.
GitHub pull request #2177 of commit c5137f73f140c424fdc739ad159c8afbce1ade95, no merge conflicts.
GitHub pull request #2174 of commit 77391fda7f78ffdb3c84f1471fa29e86c5c5026f, no merge conflicts.
GitHub pull request #2177 of commit 5a5e3fd09c397545b175a3e6b730ee86028ed8df, has merge conflicts.
GitHub pull request #2177 of commit 98bc00e3561e619f296a489a5d0d512fb10cb5d6, no merge conflicts.