Names & Labels for jenkins_node_*_builds Metrics

Steps to reproduce

The Jenkins node names are baked into the metric name making generic templates and queries impossible.

jenkins_node_my_node1_builds{quantile="0.5",} 0.640805186 (and other quantiles)
jenkins_node_my_node1_builds_count 99.0

jenkins_node_my_node2_builds{quantile="0.5",} 0.640805186 (and other quantiles)
jenkins_node_my_node2_builds_count 99.0

Expected behaviour

The node name should be taken out of the metric name and into a label. This allows for templating of nodes statistics and prevents manual work when adding a new node.

jenkins_node_builds{quantile="0.5",node="my_node1"} 0.640805186 (and other quantiles)
jenkins_node_builds_count 99.0 {node="my_node2"} 

jenkins_node_builds{quantile="0.5"node="my_node2"} 0.640805186 (and other quantiles)
jenkins_node_builds_count{node="my_node2"} 99.0

Server configuration

Jenkins Version: 2.235.5

Plugin Version: 2.0.8

Notify

@markyjackson-taulia

[james-m-tubbs]

I don’t mind sending a PR either!

[james-m-tubbs]

@markyjackson-taulia it’s not so much for me - this is a metric naming best practice thing. Makes it a lot easier for PromQL users downstream, especially, in theory, with things like dynamic agents.

That said though, deleting the old metrics names is going to break a bunch of existing user’s dashboards. If we decide to implement i’m not sure how best to approach this. Keep old metrics with a deprecation warning? Behind a config flag maybe (i don’t even know if we can do that).