Potential Mistake in translate.js leads to performance issue

Hello team,

why is here an addBack??!

In some occasions this leads to document beeing included into the search, thus find("*") matches every single element on the page:

Yes, this is followed by some filters, but still, why do one pass a container to look in, when afterwards whole page gets scanned anyway?

On my (quite strong) machine this leads to 360ms delay loading the devices.

Thanks and best regards

Thiemo

[theimo1221]

Atleast on my machine switching the speed increased quite a lot:

360ms at the start and now 12ms

[theimo1221]

I guess I solved the puzzle:

Calls:

1. their original one having 40625 matches.
2. Without the .addBack() having 0 matches
3. Checking which elements where selected before the filter
4. Swapping the order of find("*") and .addBack() resulting in 286 matches, all being within the specified container (".j_rooms, .j_functions")

So in my opinion, they not just wanted to find those containers, but also all elements within those containers. Keeping that in mind .addBack() is definitly necessary but has to be after the lookup for all elements within. So swapping lines 20 and 21 within translate.js results in following logic:

1. Find the desired containers
2. Find all the elements within the desired container
3. Merge both set of found elements
4. …

I’ll prepare a PR later on