Pre-push hook shows an error

In Windows 10, you can see hook install task generate hook looks like this.

#!/bin/sh
set -e
##### KOTLINTER HOOK START #####
##### KOTLINTER 3.4.4 #####
GRADLEW=C:\Users\rlcks\workspace\freelec\gradlew.bat
if ! $GRADLEW lintKotlin ; then
    echo 1>&2 "\nlintKotlin found problems, running formatKotlin; commit the result and re-push"
    $GRADLEW formatKotlin
    exit 1
fi
##### KOTLINTER HOOK END #####

And this shows error with message below.

.git/hooks/pre-push: line 6: C:Usersrlcksworkspacefreelecgradlew.bat: command not found
\nlintKotlin found problems, running formatKotlin; commit the result and re-push
.git/hooks/pre-push: line 8: C:Usersrlcksworkspacefreelecgradlew.bat: command not found
error: failed to push some refs to 'https://github.com/nkgcp/freelec.git'

It seems like \ in the hook file is recognized as escape character. Changing \ to \\ or / makes it works fine.

[jeremymailen]

Nothing to be sorry about. I am not sure how to verify a fix. I think a possible solution could be altering gradlew.path to gradlew.invariantSeparatorsPath in the gradleCommand val of GitHookTask.kt. But not sure how to verify it.

On your pull request branch you can bump version, publish to maven local, and then in your test project put mavenLocal() first in the repo list and pull in the version of kotlinter built by your PR. At least that’s what I usually do.

The solution might be straightforward, but I always like to see a shell script run for real on the OS, make sure it doesn’t need quoting or anything else like that – still returns an exit code.

[rvplauborg]

Nothing to be sorry about. I am not sure how to verify a fix. I think a possible solution could be altering gradlew.path to gradlew.invariantSeparatorsPath in the gradleCommand val of GitHookTask.kt. But not sure how to verify it.