Add specs for auth.service

At the start there were no tests involved in this sample. But since many people found the repository useful, and probably use mainly auth.service.ts as a starting point for their application, it seems useful to add a spec for the core thing they can copy/paste along.

I’m tagging this issue hacktoberfest/up-for-grabs, mainly because creating a start for all of this is something that can be picked up when you start out.

I prefer to have multiple PRs to do this in steps:

1. First PR to re-enable jasmine and test running for this repository, with just 1 it spec for auth.service.ts, that runs as part of the GitHub Actions pipelines (can be a dummy test)
2. Second PR to properly add a good mock for the OAuthService and then test the runInitialLoginSequence logic branches
3. Optionally a third PR to add some Jasmine Marbles based testing, to see what happens in various sequences

Let us know in the issue if you want to pick up any of these and at which timing, to prevent getting conflicts if multiple PRs come in.

(If no one feels like it that’s also fine! Then I might add it myself, later. For now I commit to actively watching for incoming PRs.)

[valburyakov]

@jeroenheijmans Thx for feedback, glad to help. I think with auth-service we’re done and you can close this issue.

[jeroenheijmans]

PR #67 was some more excellent work! ❤️

The most important thing we now have: a test setup so that

• A. People using this sample as a starter would have proper tests in their codebase.
• B. A setup that allows us to TDD additions and changes to this sample

Adding more tests now (more coverage in general, or Jasmine marbles tests, for fun) is in my opinion welcome-but-optional.

I’ll leave the issue open for a moment. @valburyakov if you want to continue the hacktoberfest PR streak and add a follow-up, you’d be most welcome. If you feel it’s all good for now, that’s totally fine too (and then I’d probably close this issue, maybe create a fresh follow-up issue).