Goals for a new Inventory

Alright, I think it’s time to finally sit down and rewrite the inventory system. The current one has a lot of issues. Here’s a list of goals I’d like to accomplish:

• Consolidate Item and Inventory into single classes. No more of this “grabbing the description for an item” crap. No more separate Inventory classes for TF2 vs. other games. No more “Item may have a Schema.Item, Inventory.Item, or both, depending on circumstances”.

  Note that we may still have multiple classes for different Inventory/Item types, but they should all be derived from a common base class.

• Inventory should work with “friends-only” inventories, and private inventories during a trade.

• Bot should not block the trade while waiting for inventories to load. Probably the easiest way to make this happen is to not call OnTradeItemAdded until all Inventories have been loaded.

• Inventory should work with more than 2500 items.

• Inventory should be loaded using the correct URL (if that’s even possible)

• Should be compatible with StormReaper’s TradeOffer PR, since a lot of people are using that. Add partnerInventory API support.

• New: Should work with items that have amounts, like gems.

• As an optional goal, should work with Spiral Knights (does anyone even care about this?)

Can anyone think of anything else?

This is going to be a major breaking change, but I think that’s acceptable. This has been a long time coming.

[aleksamagicka]

Any news? It’s been almost a year.

[ghost]

I dislike bumping old issues such as this. However, after watching the Steam API recently, I feel as though we need to have some of this pushed/updated as the API has become more and more unstable recently causing the bot to fail to login which if this was to be pushed, this would remove some of these issues.