Bad typing for `toHaveBeenCalledOnceWith` causing problems

Bug

• package version: 3.1.0
• node version: 18.10.0
• npm (or yarn) version: 8.19.2

What happened:

A test with the following line passes, but TypeScript complains with Expected 0 arguments, but got 1. ts(2554):

expect(revealSpy).toHaveBeenCalledOnceWith({ nodes: [node], index, parent });

reveal and revealSpy are defined as follows:

const revealSpy = jest.spyOn(mdastUtilHidden, 'reveal').mockImplementation(() => undefined);

// Exported as part of mdastUtilHidden
function reveal<Nodes extends Hidden[]>({
  nodes,
  index,
  parent
}: {
  nodes: Nodes;
  index: number;
  parent: Parent<Node<Data>>;
}) {
  parent.children.splice(
    index,
    1,
    ...nodes.flatMap((n) => n.hiddenChildren.map((n) => removePosition(n)))
  );
}

I saw a recent commit described as “fixing toHaveBeenCalledOnceWith,” so this may be a regression. Potentially related to #517. I’ve used @ts-expect-error to ignore the TS error for now. EDIT: expect(...).toHaveBeenNthCalledWith(1, ...) also works. Thanks for your work on this package!

Reproduction repository: https://github.com/Xunnamius/unified-utils/blob/b84a05ab0a10dd38b2c46062452f6c3e6cec194a/packages/mdast-util-hidden/test/unit-index.test.ts#L215

[keeganwitt]

Simen just did a 3.2.0 release that contains this fix.

[keeganwitt]

Yea, this was a simple goof in the type file. We currently lack test coverage of our types, but this is something we plan on adding.