Is the code coverage markup working properly?

I’m a bit confused by the code coverage highlighting. Is it working as expected? /cc @bookman25?

Here’s the HTML reporter compared to our overlay:

Steps to Reproduce

Here’s the repo for the example:

git clone https://github.com/seanpoulter/issue--jest-community--vscode-jest--181

[bookman25]

I’m all in favor of adding more tests. I’m not attached to any of the code. If you find a way to improve the code so it makes more sense and is easier to maintain, then by all means feel free.

[seanpoulter]

@bookman25, are you OK if I refactor overlay.ts as a class so it’s easier to test? I’m just getting familiar with Jest’s mocking, but it seems let testing a lot easier to manage mocks when you’re checking behavior (e.g.: callFoo() calls foo().

// module.test.ts
import m from './module'

it('calls foo', () => {
  (m.foo as any) = jest.fn()
  m.callFoo()
  expect(m.foo).toBeCalled()      // Nope: Expected mock function to have been called
})

it('is not a mock', () => {
  expect(m.foo.mock).not.toBeDefined()   // Nope: Expected value not to be ... a mock!
})


// class.ts: OK
import { C } from './class'

it('calls foo', () => {
  const c = new C()
  c.foo = jest.fn()
  c.callFoo(args)
  expect(c.foo).toBeCalledWith(args)
})

it('is not a mock', () => {
  const c = new C()
  expect(c.foo.mock).not.toBeDefined()
})

Full disclosure: That’s how I’ve been adding tests but I wanted to check in before I bother with a PR.