Toggling coverage overlay requires refreshing page
See original GitHub issueEnvironment
-
node -v
: v8.6.0 -
npm -v
: 5.3.0 -
npm ls react-scripts
(if you haven’t ejected): (empty) -
Operating system: macOS 10.13.1
Steps to Reproduce
Coverage overlay is not shown. Do Toggle coverage overlay
. Still not shown. Switch to another file. Switch back. Overlay is shown.
Expected Behavior
Coverage overlay is not shown. Do Toggle coverage overlay
. Overlay is shown.
Actual Behavior
See above.
In overlay.ts we’re just doing () => (showCoverage = !showCoverage)
, but I don’t think that makes anything happen, like the page refreshing (or whatever you’re supposed to do with the extension API.) How would one add that?
Also, if someone were to add an indicator that the coverage overlay were on or off, where would be the best place to do that? I was thinking maybe the lens at the top could show lines: ..., branches: 95%, overlay: true
but I’d like some better opinions. Thanks!
Issue Analytics
- State:
- Created 6 years ago
- Reactions:1
- Comments:7 (5 by maintainers)
Top GitHub Comments
I really think that somewhere it should tell me whether the coverage overlay is on or off. Doesn’t need to be in a lens at all, but there’s no way of telling right now and it’s frustrating.
Yes, but I’m not at all familiar with the extension API. Where would I start? I understand the code that’s there but am having trouble finding how to trigger a refresh or whatever the proper thing to do would be.
But the quick pick menu … 😉