EntityHook: Duplicate EntityChanges per transaction

I have a question about the entity hook and the registered entity changes.

https://github.com/JetBrains/Exposed/blob/7e3c74232406b1d60609a5b8a856a7bffe4a8135/exposed-dao/src/main/kotlin/org/jetbrains/exposed/dao/EntityHook.kt#L37-L41

When a change gets registered there is a check if that change was already registered. But the code above only checks if the last added change is equal to the current change. If there was a different change in the meantime the duplicate change will be registered anyhow. I’m not sure if this is on purpose but I would consider all changes on the same entity in the same transaction to be ‘one’ change in any case (also if there are changes on other entities in between). So I would change the code to this:

fun registerChange(transaction: Transaction, change: EntityChange) { 
     if (change !in transaction.entityEvents) { 
         transaction.entityEvents.add(change) 
     } 
 } 

What is your opinion about this?

[mpe85]

@Tapac Thanks for the feedback. What would also help is to provide some kind of transaction identifier in the entity change event so the subscribers know which events were triggered within the same transaction. Maybe each transaction could have a unique UUID which is used for this. What do you think?

[Tapac]

Released in 0.20.1