reWriteBatchedInserts does not work with PostgreSQL

I’m trying to use reWriteBatchedInserts with a PostgreSQL database. According to pgjdbc the rewrite is possible only if no return values are requested.

In InsertStatement.kt:

    override fun prepared(transaction: Transaction, sql: String): PreparedStatementApi = when {
        // https://github.com/pgjdbc/pgjdbc/issues/1168
        // Column names always escaped/quoted in RETURNING clause
        autoIncColumns.isNotEmpty() && currentDialect is PostgreSQLDialect ->
            transaction.connection.prepareStatement(sql, true)

        autoIncColumns.isNotEmpty() ->
            // http://viralpatel.net/blogs/oracle-java-jdbc-get-primary-key-insert-sql/
            transaction.connection.prepareStatement(sql, autoIncColumns.map { it.name.inProperCase() }.toTypedArray())

        else ->
            transaction.connection.prepareStatement(sql, true)
    }

So the prepare statement is always call with true.

In JdbcConnectionImpl:

    override fun prepareStatement(sql: String, returnKeys: Boolean) : PreparedStatementApi {
        val generated = if (returnKeys)
            PreparedStatement.RETURN_GENERATED_KEYS
        else
            PreparedStatement.NO_GENERATED_KEYS
        return JdbcPreparedStatementImpl(connection.prepareStatement(sql, generated), returnKeys)
    }

So every insert requests set returnKeys to PreparedStatement.RETURN_GENERATED_KEYS.

The consequence is that the optimization implies by reWriteBatchedInserts is not done.

Am I missing something?

ps: I’m using batchInsert and I set reWriteBatchedInserts to true correctly (I checked it in debug). I also tested some inserts using directly the jdbc api and the rewrite worked (I saw it in postgresql logs).

[ekans]

@Tapac for your information I just tested version 0.25.1 and it works great! Thanks.

[Tapac]

Today or tomorrow.