Tracking of ignored files showing false positives.

Received notice that

Ignored files found that are tracked: .ignore plugin found some files that are tracked with Git which are also listed in .gitignore file.

However, the file being highlighted is gradle-wrapper.jar which is in my .gitignore file as this:

# Avoid ignoring Gradle wrapper jar file (.jar files are usually ignored)
!gradle-wrapper.jar

Earlier I also noticed that log4j2.properties file which is in my build folder was similarly being marked. It is of course included in git in the main project, and my build folder is added to .gitignore, so this rule seems a little confused.

[hsz]

@rscorer @akomelj @bamapookie @SUPERCILEX @HeadOnAPlate @bamapookie @pbienick Thank you guys for this feedback.

I finally was able to resolve this issue (mostly with reimplementing the indexing part). The main issue that caused this bug was wrongly handled files excluding with ! at the beginning (it was commited to #350).

This fix will be released with v2.0.0 as soon as I’ll take care of the other issues (I’m back on track for last 2 weeks).

CC @cjbarth @pvannuff @bamapookie @Hronom

[rscorer]

Interesting, I thought I’d try something quickly - and apparently its all git’s fault.

If I edit my .gitignore I can avoid this issue…

Previously:

$ cat .gitignore
...
# Avoid ignoring Gradle wrapper jar file (.jar files are usually ignored)
!gradle-wrapper.jar
...
# Package Files #
*.jar
*.war
*.ear
*.zip
*.tar.gz
*.rar

...

$ git ls-files --ignored --exclude-standard
gradle/wrapper/gradle-wrapper.jar
$

Edited, I end up with this:

$ cat .gitignore
...
# Package Files #
*.jar
*.war
*.ear
*.zip
*.tar.gz
*.rar

# Avoid ignoring Gradle wrapper jar file (.jar files are usually ignored)
!gradle-wrapper.jar

...

$ git ls-files --ignored --exclude-standard
$ 

Previously the Avoid line was placed before the *.jar line

So the order is apparently very important

(Hope that makes sense)