Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Wrong behavior of `application/wasm` mime type

See original GitHub issue

Current webassebmly spec says

Note: extra parameters are not allowed, including the empty application/wasm;. https://webassembly.github.io/spec/web-api/index.html#streaming-modules

For now ecstatic adds charset in Content-Type for all filetypes, so mimetype for wasm files will be application/wasm; charset=utf-8. Can we somehow disable this for files with application/wasm mimetype (or for binary files at all?)?

I’ll be happy to create PR if you tell me right way to figure out exclusions.

Issue Analytics

State:
Created 6 years ago
Reactions:5
Comments:12 (8 by maintainers)

Top GitHub Comments

3reactions

jfhbrookcommented, Apr 20, 2018

https://github.com/jfhbrook/node-ecstatic/blob/master/lib/ecstatic.js#L242-L247 potentially a bug in mime@1 ? upgrading mime is part of a bigger project.

1reaction

dcodeIOcommented, Apr 20, 2018

Yeah, I think that’s the cause. Seems that the mime package removed the charset functionality entirely in v2. Ideally, if there’d be a way to detect that a mime type is indicating a binary file, appending the charset could simply be skipped, or something like that.