no-mutating-assign and functions

This doesn’t pass the no-mutating-assign rule:

Object.assign(() => {}, {foo:1});

Should it be allowed?

[graingert]

I can see:

const foo = Object.assign(function foo(ham) { }, { $inject: ['ham'] });

being preferred to:

const foo = function foo(ham) { };
foo.$inject = ['ham'];

[jdiamond]

Hey thanks! I upgraded and was able to remove my comments disabling the rule.

You’re right that no-mutation is the error I get when trying to assign propTypes the old-fashioned way. I think I assumed no-unused-expression because that’s the error I’ve been seeing the most lately as I try to write in a more functional style.

I didn’t know about the exceptions property so thanks for that. I agree that passing an arrow function to Object.assign looks very funny. Just trying it out for now.

Thanks again for the awesome plugin!