Using jfrog/setup-jfrog-cli without internet access
See original GitHub issueIs your feature request related to a problem? Please describe. We have noticed that this action calls out to the internet to download the latest cli files. We use GitHub Enterprise Server, and due to company restrictions, we cannot access the internet from our action, therefore this action is currently a problem for us. Here’s an example of where the remote url to download the jfrog cli is hardcoded.
https://github.com/jfrog/setup-jfrog-cli/blob/master/src/utils.ts
Describe the solution you’d like to see Can we add a parameter to specify the location (internal) to download the CLI? For example:
- uses: jfrog/setup-jfrog-cli@v2
with:
- path: https://internallocation.mycompany.com/jfrog-cli
Describe alternatives you’ve considered One alternative is to fork and make the change ourselves, but we’d prefer to use the public action. We suspect there are others with similar requirements who would benefit from this.
Issue Analytics
- State:
- Created a year ago
- Reactions:2
- Comments:7 (4 by maintainers)
Top GitHub Comments
Hi @yahavi ,
That looks like a good solution, and would work our firmwide Artifactory instance.
Hi @samsmithnz, thanks for requesting this feature! 🚀
We had a team conversation about it and we think that the solution should be a bit different - instead of providing a full URL, provide a name of a remote generic repository in Artifactory pointing to https://releases.jfrog.io/artifactory/jfrog-cli/. For example:
This suggested solution is similar to the one used in the JFrog Azure DevOps extension: https://www.jfrog.com/confluence/display/JFROG/JFrog+Azure+DevOps+Extension#JFrogAzureDevOpsExtension-JFrogToolsInstaller
We will add this feature to our plan and will keep you updated. Please let me know what do you think.