Support for System.Text.Json

The built-in JSON serializer uses Newtonsoft.Json. But in ASP.NET Core 3.0, the default serializer is System.Text.Json. It would be nice if Tiny.RestClient supported it, because:

• It has better performance than Newtonsoft.Json
• If the rest of the application uses System.Text.Json, it would be better if everything used it. It would be more consistent, and would allow reuse of the same settings, converters, etc.

It’s easy enough to implement a IFormatter that uses System.Text.Json, but there’s a bit of an impedance mismatch between the IFormatter and System.Text.Json APIs… IFormatter only has synchronous methods that take a Stream. But System.Text.Json doesn’t have synchronous methods that accept a stream, only async ones. And they return a ValueTask, so we can’t just use .Result. Maybe the solution would be to add a IAsyncFormatter interface. If the formatter implements it, use the async methods, if not, use the sync methods.

[jgiacomini]

Hello guys,

I have a PR ready which remove NewtownSoft.Json and make library compatible with System.Text.Json.

I will release this week the version 2.0 of the library

I am also writing benchmarks to try to remove unecessary allocations.

[thomaslevesque]

being able to change serializer would be great

It’s already possible today, by providing your own implementation of IFormatter. Anyway, maybe Newtonsoft.Json support could be provided as a separate package.

also be able to use protobuf since the GRPC Protocol is increasingly used

Yes, but GRPC is not ReST…