coding convention followups for color refinement
See original GitHub issueThese are some leftover issues from #615, which has already been merged. For the naming convention, please make sure these get applied to other pending pull requests as well.
- Non-obvious data member names such as “k” should have a comment explaining their purpose (regardless of whether they are defined in the paper). Better would be to use a meaningful name and then make clear the correspondence to variables defined in the paper via a comment at the point of definition.
- Variable names should start with a lowercase letter, and except for local variables such as loop iterators, should have meaningful names.
- Arrays should be 0-based, not 1-based, unless you are programming in FORTRAN 😃
- Add the
@throwsJavadoc mentioned by @d-michail to the IsomorphismInspector interface for documentation purposes (making clear that not all inspector implementations are subject to this limitation, so the caller should refer to the Javadoc for the actual implementation used)
Issue Analytics
- State:
- Created 5 years ago
- Comments:5 (3 by maintainers)
Top Results From Across the Web
canonical forms, over-coloring, and polytime graph isomorphism
This paper will discuss the pseudo code for these algorithms, ... number of vertices, color refinement fails to successfully identify them as non-isomorphic ......
Read more >The Iteration Number of Colour Refinement - arXiv
In an iterative fashion, it refines an isomorphism-invariant partition of the vertex set of the input graph. This process stabilises at some ...
Read more >A visual demo of the color refinement algorithm - GitHub
The color refinement algorithm is a heuristic method to detect whether two graphs are isomorphic (see, e.g., [GKMS17+]). It is also known as...
Read more >Color Refinement and its Applications
Abstract. Color refinement is a simple algorithm that partitions the vertices of a graph according their “iterated degree sequence.
Read more >Graph coloring - Wikipedia
The convention of using colors originates from coloring the countries of a map, where each face is literally colored. This was generalized to...
Read more >
Top Related Medium Post
No results found
Top Related StackOverflow Question
No results found
Troubleshoot Live Code
Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free
Top Related Reddit Thread
No results found
Top Related Hackernoon Post
No results found
Top Related Tweet
No results found
Top Related Dev.to Post
No results found
Top Related Hashnode Post
No results found

@jsichi Unfortunately, I cannot assign it to me as well, nevertheless, I have it in mind. We will correct this with the individualization refienement PR.
Yep, we’ll take a look at that next.