question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

coding convention followups for color refinement

See original GitHub issue

These are some leftover issues from #615, which has already been merged. For the naming convention, please make sure these get applied to other pending pull requests as well.

  • Non-obvious data member names such as “k” should have a comment explaining their purpose (regardless of whether they are defined in the paper). Better would be to use a meaningful name and then make clear the correspondence to variables defined in the paper via a comment at the point of definition.
  • Variable names should start with a lowercase letter, and except for local variables such as loop iterators, should have meaningful names.
  • Arrays should be 0-based, not 1-based, unless you are programming in FORTRAN 😃
  • Add the @throws Javadoc mentioned by @d-michail to the IsomorphismInspector interface for documentation purposes (making clear that not all inspector implementations are subject to this limitation, so the caller should refer to the Javadoc for the actual implementation used)

Issue Analytics

  • State:closed
  • Created 5 years ago
  • Comments:5 (3 by maintainers)

github_iconTop GitHub Comments

1reaction
christophgruenecommented, Jul 11, 2018

@jsichi Unfortunately, I cannot assign it to me as well, nevertheless, I have it in mind. We will correct this with the individualization refienement PR.

0reactions
jsichicommented, Oct 10, 2018

Yep, we’ll take a look at that next.

Read more comments on GitHub >

github_iconTop Results From Across the Web

canonical forms, over-coloring, and polytime graph isomorphism
This paper will discuss the pseudo code for these algorithms, ... number of vertices, color refinement fails to successfully identify them as non-isomorphic ......
Read more >
The Iteration Number of Colour Refinement - arXiv
In an iterative fashion, it refines an isomorphism-invariant partition of the vertex set of the input graph. This process stabilises at some ...
Read more >
A visual demo of the color refinement algorithm - GitHub
The color refinement algorithm is a heuristic method to detect whether two graphs are isomorphic (see, e.g., [GKMS17+]). It is also known as...
Read more >
Color Refinement and its Applications
Abstract. Color refinement is a simple algorithm that partitions the vertices of a graph according their “iterated degree sequence.
Read more >
Graph coloring - Wikipedia
The convention of using colors originates from coloring the countries of a map, where each face is literally colored. This was generalized to...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found