Ng2 router should store destination route

To avoid forgetting it as this is the last issue to solve before being able to remove ui-router completely from package.json

register-transition-hooks.ts used to configure ui-router , it had 3 responsibilities on state transitions:

1. store destination state in case to bring user to it later in case she has to login first
2. support for external URLs in ui-router
3. set page title

Only first one is not yet covered and relates to StateStorageService that should probably be renamed to RouteStorageService.

    $transitions.onStart({}, (transition: Transition) => {
        let $storageService = transition.injector().get(StateStorageService);
        $storageService.storeDestinationState(transition.to(), transition.params(), transition.from());
        let principal = transition.injector().get(Principal);
        let auth = transition.injector().get(AuthService);
        if (principal.isIdentityResolved()) {
            auth.authorize();
        }

        <%_ if (enableTranslation) { _%>
        // Update the language //FIXME not sure if this is required, its causing some weird error as well
        /*let languageService = transition.injector().get(JhiLanguageService);
        languageService.getCurrent().then(current => {
            languageService.changeLanguage(current);
        });*/
        <%_ } _%>
    });

[VictorADS]

I’m on it

[deepu105]

I hope so

Thanks & Regards, Deepu

On Tue, Jan 24, 2017 at 10:19 AM, VictorADS [e-mail] wrote:

@deepu105 https://github.com/deepu105 I wouldn’t call this workarounds, it’s just another way to treat routes. Also, even though it was easier in ui-router, I remember it had some problems with regards to the transition hooker. I think migrating to ng-router is for the better

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/jhipster/generator-jhipster/issues/4930#issuecomment-274750058, or mute the thread https://github.com/notifications/unsubscribe-auth/ABDlFzPFqQp_0lD4USxg0q6Oe4fVk9gSks5rVcI1gaJpZM4LqjHI .