Issue Invites With Domain Name Instead of IP Address
See original GitHub issueOutline Manager currently accepts configuration strings that contain a domain name instead of the server’s IP address in apiUrl
. However, invites issued by the app still contain the IP address.
It would be great if invites issued by Outline Manager that is configured with a domain name referenced the same domain name instead of the server’s IP address.
Right now, it is possible to manually replace IP addresses with domain names in invites, but less tech-savvy users may get stuck on this step.
Example
Outline Manager accepts this:
{ "apiUrl": "https://node1.outline.example.com:1234/V0exXlX58SvhD_6kmCME3A", "certSha256": "B06368232C4769A6D14962F76F0BEB4A75DFFAC1FE7EB5230E4D9824AB0BFCA3" }
Still, invites created with Outline Manager look like this:
ss://1234abcd1234abcd1234abcd1234abcd1234abcd1234abc=@127.0.0.1:1234/?outline=1
It would be nice if invites looked like this:
ss://1234abcd1234abcd1234abcd1234abcd1234abcd1234abc=@node1.outline.example.com:1234/?outline=1
Issue Analytics
- State:
- Created 5 years ago
- Reactions:6
- Comments:5 (2 by maintainers)
Top GitHub Comments
@yakovmanshin Thanks for the feedback! I’m glad you were able to get connected. Yes, it would be nice if the manager offered to use a domain name rather than IP. This is a feature we’ll be looking into.
As hostname is written when access key is created, this hostname is injected trough an environment variable and that variable is, presumably, transpiled in the build step, I think that it will be necessary to read hostname from other source that do not require to rebuild Docker image.
I think it is related with this.
Correct me if I’m wrong but, ¿is it possible that, currently, if we put the domain instead the raw IP on the initial setup the keys will be generated with domain name?