Unable to find constructure w/ JDK11-OpenJ9

Describe the bug Unable to create NPCs. Reflection is unable to locate the correct constructor.

NPCLib usage option 3

NPCLib JAR name 2.4.1 Plugin shaded into JAR

Server version PaperSpigot-4c7641d (aka; paper-443 for 1.8.8)

To Reproduce Create an NPC using any of the create methods.

Expected behavior n/a

Screenshots

> [06:07:18 ERROR]: [ACF] Caused by: java.lang.IllegalStateException: Unable to find constructor for class net.minecraft.server.v1_8_R3.EntityArmorStand ([class net.minecraft.server.v1_8_R3.WorldServer]).
> [06:07:18 ERROR]: [ACF] at com.comphenix.tinyprotocol.Reflection.getConstructor(Reflection.java:279)
> [06:07:18 ERROR]: [ACF] at net.jitse.npclib.hologram.Hologram.createPackets(Hologram.java:117)
> [06:07:18 ERROR]: [ACF] at net.jitse.npclib.hologram.Hologram.<init>(Hologram.java:92)
> [06:07:18 ERROR]: [ACF] at net.jitse.npclib.nms.v1_8_R3.NPC_v1_8_R3.createPackets(NPC_v1_8_R3.java:39)
> [06:07:18 ERROR]: [ACF] at net.jitse.npclib.internal.NPCBase.create(NPCBase.java:132)
> [06:07:18 ERROR]: [ACF] at net.gravitas.gravitasapi.npcs.CustomNPC.build(CustomNPC.java:201)

Additional context We’re using Java 11-OpenJ9. The issue also appeared on our 1.14.4 instances, but was fixed as it was a custom Spigot build, simply by adding a new constructure using WorldServer instead of World (see below).

    // custom constructure to allow NPCLib to correctly target a constructor
    public EntityArmorStand(WorldServer world, double d0, double d1, double d2) {
        this(EntityTypes.ARMOR_STAND, world);
        this.setPosition(d0, d1, d2);
    }

    public EntityArmorStand(World world, double d0, double d1, double d2) {
        this(EntityTypes.ARMOR_STAND, world);
        this.setPosition(d0, d1, d2);
    }

I expect this issue is due to Java 11 and the Reflection class not accepting superclasses as a valid option.

[JitseB]

Solved. Will soon post a release with the fix.

[JitseB]

https://github.com/JitseB/NPCLib/releases/tag/2.4.2-SNAPSHOT