Method mismatch when expecting a true or false result

Since Boolean.getBoolean(str) will always return false in this code block if(!Boolean.getBoolean(StackProperties.KEEP_CRANS_AFTER_A_RESPONSE)), I believe it is in error and that this is actually what was intended if(!StackProperties.getBoolean(StackProperties.KEEP_CRANS_AFTER_A_RESPONSE, false))

This is the only way to get true via Boolean.getBoolean("true").

https://github.com/jitsi/ice4j/blob/94b3cb2661836f39477c1d18e14347b2a0174f16/src/main/java/org/ice4j/stack/StunClientTransaction.java#L495

[bgrozev]

You might want to take a closer look @bgrozev before discounting what I’m informing you about.

I am not discounting what you wrote and I did take a closer look. In fact, I went as far as running a test program just in case I missed something:

import java.util.*;
import java.net.*;


public class Test
{
  public static void main(String[] argv)
  throws Exception
  {

   System.err.println(Boolean.getBoolean("org.ice4j.PROP"));
  }
}

The result is this:

$ java  -Dorg.ice4j.PROP=true Test
true
$ java  -Dorg.ice4j.PROP=false Test
false

What am I failing to get across here?

You are failing to read the documentation that I first quoted and then linked to.

[bgrozev]

As documented, the argument passed to Boolean.getBoolean() names a system property which will be checked, which is exactly what we provide: https://docs.oracle.com/javase/7/docs/api/java/lang/Boolean.html#getBoolean(java.lang.String)