Gravatars are loaded with disableThirdPartyRequests set to true

Description

I set disableThirdPartyRequests to true, but I am still seeing my Gravatar image being displayed when I switch off the camera. Also according to network inspector there are still calls being made to gravatar.com.

This is unexpected since the comment states:

// If third party requests are disabled, no other server will be contacted.
// This means avatars will be locally generated and callstats integration
// will not function.
disableThirdPartyRequests: true,

Current behavior

gravatar.com is still being called.

Expected Behavior

gravatar.com should not be called.

Steps to reproduce

Set disableThirdPartyRequests: true, and check the network inspector during a page reload.

Environment details

jitsi-meet 2.0.4384-1 on Debian 10.3

[Commifreak]

Same here. In addition, a request to callstats.io is made to load the Main JS! Both should be disabled with disableThirdPartyRequests: true,

GET | https://api.callstats.io/static/callstats-ws.min.js
-- | --



GET /static/callstats-ws.min.js HTTP/1.1
Host: api.callstats.io

[csett86]

I debugged into this first of all, the behaviour is still present in current stable (2.0.5870) and master (f84f7332b9205652a7e9cd8772d05c6fd98e0329) and I found out the following:

When handling the PARTICIPANT_JOINED action, the ‘features/base/config’ state is empty, thus disableThirdPartyRequests is undefined, ie falsy, which means that the preloading of the avatar is triggered. I debugged this by showing the full redux state in the middleware of participants (https://github.com/jitsi/jitsi-meet/blob/f84f7332b9205652a7e9cd8772d05c6fd98e0329/react/features/base/participants/middleware.js#L410):

Unfortunately my react / redux skills are not good enough to propose a fix for this, but maybe this debugging helps someone to fix it.