question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

LIBRE_BUILD sdk still pulls in gms dependencies

See original GitHub issue

I’ve been investigating the element-android containing proprietary gms libraries again through the use of the jitsi-meet sdk, even though it’s explicitly using an sdk built with LIBRE_BUILD=true.

I believe this is happening because jitsi-meet sdk is now unconditionally including a library that (optionally?) depends on gms libs and only conditionally excluding these transitive dependencies. Previously it only conditionally included the libs in the not-LIBRE variant. See here: https://github.com/jitsi/jitsi-meet/blob/7a64bf006ea027b77564d8847570e1ac46ff0ec0/android/sdk/build.gradle#L53

Unfortunately the exclusion rules don’t propagate to consumers of the sdk, which need to be aware of the latest jitsi exclusion rules and apply them to the jitsi dependency themselves. I’d hope there’s a way of excluding these transitive dependencies at the jitsi sdk level, so I’m not sure how exactly. Maybe a modified (excluding the proprietary dependencies from the pom file) version of the react-native-device-info dependency could be published to the maven repo if we are doing a libre build?

Fix at element-android side: https://github.com/vector-im/element-android/pull/3125

I’d appreciate your input, @saghul 😃.

Issue Analytics

  • State:closed
  • Created 2 years ago
  • Comments:13 (4 by maintainers)

github_iconTop GitHub Comments

1reaction
stale[bot]commented, Jul 8, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

0reactions
licaon-ktercommented, Feb 1, 2022
Read more comments on GitHub >

github_iconTop Results From Across the Web

Caused by: groovy.lang.MissingPropertyException: Could not ...
MissingPropertyException: Could not get unknown property 'android' for task ':react-native-vision-camera:jitsiAndroidSourcesJar' of type org.gradle.api.tasks.
Read more >
android - How to fix google play service error - Stack Overflow
One of your dependency is having different version of com.google.android.gms . Update. Firebase dependencies are having independent versions ...
Read more >
Set up Google Play services
Declare dependencies for Google Play services · Open the build.gradle file inside your app's module directory. · For each SDK that your app...
Read more >
Add build dependencies - Android Developers
Learn how to add build dependencies using the Gradle build system in Android ... If the library does not already exist locally, Gradle...
Read more >
Dependencies of Firebase Android SDKs on Google Play ...
Some Firebase Android SDKs depend on Google Play services, which means they will only run on devices and emulators with Google Play services...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found