Mute Everyone Button appears even when it shouldn't
See original GitHub issueDescription:
In the App, even when the participant is not a moderator, the mute everyone button appears
Steps to reproduce:
join a room as a non moderator - open the overflow menu - you can see the mute everyone button
Expected behavior:
Server information:
- Jitsi Meet version:
- Operating System:
Client information:
- Browser / app version: 20.6.2 app
- Operating System: iOS
Additional information:
in MuteEveryoneButton.js we check for
visible: visible && isModerator && !disableRemoteMute
but visible and disableRemoteMute could be undefined. When we check for this, visible will often be undefined and thus visible, even if the button has no effect.
to fix this we could invert all the checks to avoid undefined variables:
!(!visible && disableRemoteMute && !isModerator)
seems to be working for me.
Explanation:
the expression will be true if: visible is true or undefined AND disableremotemenu is true or undefined AND you are a moderator (or it’s undefined, which should not happen I think)
Issue Analytics
- State:
- Created 3 years ago
- Reactions:1
- Comments:9 (8 by maintainers)
Top GitHub Comments
🤦 I see your screenshot now … it is no mobile … So @saghul I reproduce this on jitsi-meet app locally, so its a bug in the mobile app.
I just checked, this is fixed.