Project hygiene (js tests, node version, package vulnerabilities)
See original GitHub issueComing into this with great respect and gratitude towards everyone who has contributed to this project.
In the interest of the longevity and security of this project, I’d like to ask what is the plan for keeping this codebase in good hygiene. The reason I am concerned about it is because of the following three:
- The recommended node version is >= 10, however we are currently at the final year or support for this version, so the project needs to move to node 12 during that period
- Installing the project shows quite a lot of vulnerabilities:
found 5216 vulnerabilities (2832 low, 6 moderate, 2376 high, 2 critical)
- I can’t locate any tests for the front-end, which would provide some level of confedence when upgrading node, packages and for generally making sure bugs are cought early. (I saw this directory https://github.com/jitsi/jitsi-meet/tree/6121e9fc65340470b6c412a1e4dc6386ed3ba186/react/features/base/testing/components but I’m not entierly sure what it’s about. Also it hasn’t been updated recently).
Is your feature request related to a problem you are facing? No, not yet.
Describe the solution you’d like There can be a graduall increase in project hygiene by gothering metrics and making sure these are visible. Visibility is always the first step. Then, we could have a strategy for automated tests and allow the contributors to test their features. Then, there could be a CI task to run the tests and provide feedback on Pull Requests to make sure existing funtionallity isn’t broken.
This isn’t something that can be done in a short amount of time, but the direction needs to be there, and people will follow.
Please let me know what the Jitsi team thinks of this. Also, I am glad to contribute myself.
Issue Analytics
- State:
- Created 3 years ago
- Reactions:1
- Comments:11 (8 by maintainers)
Top GitHub Comments
Ah, no worries, I was just trying to point out that we are on it 😃
You can take a look at the integration tests https://github.com/jitsi/jitsi-meet-torture