question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Project hygiene (js tests, node version, package vulnerabilities)

See original GitHub issue

Coming into this with great respect and gratitude towards everyone who has contributed to this project.

In the interest of the longevity and security of this project, I’d like to ask what is the plan for keeping this codebase in good hygiene. The reason I am concerned about it is because of the following three:

  • The recommended node version is >= 10, however we are currently at the final year or support for this version, so the project needs to move to node 12 during that period
  • Installing the project shows quite a lot of vulnerabilities: found 5216 vulnerabilities (2832 low, 6 moderate, 2376 high, 2 critical)
  • I can’t locate any tests for the front-end, which would provide some level of confedence when upgrading node, packages and for generally making sure bugs are cought early. (I saw this directory https://github.com/jitsi/jitsi-meet/tree/6121e9fc65340470b6c412a1e4dc6386ed3ba186/react/features/base/testing/components but I’m not entierly sure what it’s about. Also it hasn’t been updated recently).

Is your feature request related to a problem you are facing? No, not yet.

Describe the solution you’d like There can be a graduall increase in project hygiene by gothering metrics and making sure these are visible. Visibility is always the first step. Then, we could have a strategy for automated tests and allow the contributors to test their features. Then, there could be a CI task to run the tests and provide feedback on Pull Requests to make sure existing funtionallity isn’t broken.

This isn’t something that can be done in a short amount of time, but the direction needs to be there, and people will follow.

Please let me know what the Jitsi team thinks of this. Also, I am glad to contribute myself.

Issue Analytics

  • State:closed
  • Created 3 years ago
  • Reactions:1
  • Comments:11 (8 by maintainers)

github_iconTop GitHub Comments

1reaction
saghulcommented, May 20, 2020

Ah, no worries, I was just trying to point out that we are on it 😃

1reaction
damenchocommented, May 10, 2020

You can take a look at the integration tests https://github.com/jitsi/jitsi-meet-torture

Read more comments on GitHub >

github_iconTop Results From Across the Web

test-node-js - npm Package Health Analysis - Snyk
The npm package test-node-js was scanned for known vulnerabilities and missing license, and no issues were found. Thus the package was deemed as ......
Read more >
AppSec POV on Dependency Management - The npm Blog
Review the version history of the package to ensure a healthy release cadence has been established by the package maintainers. A slowing or ......
Read more >
React.js Security Guide: Threats, Vulnerabilities, and Ways to ...
If you think about using React.js, take a deeper look at its security vulnerabilities and best practices to protect your future solution.
Read more >
CVE-2021-21315 Detail - NVD
The System Information Library for Node.JS (npm package "systeminformation") is an open source collection of functions to retrieve detailed ...
Read more >
Sonatype Overhauls JavaScript Scanning & Provides npm ...
Sonatype's enhanced JavaScript solutions take advantage of new algorithms to better identify security vulnerabilities in open source npm packages.
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found