question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

"Video Share" feature flag not respected on Android

See original GitHub issue

Description:

I have set the feature flag video-share.enabled to false. It works well on iOS.

However, testing it, the video sharing button is still shown for Android phones. In particular, Galaxy S9 (Android 10)

https://github.com/jitsi/jitsi-meet/blob/7f5751b9185b406a55e22b0df204620f56eae1b0/react/features/base/flags/constants.js

Steps to reproduce:

In MainActivity.java I have changed the following function:

private void setJitsiMeetConferenceDefaultOptions() {
        // Set default options
        JitsiMeetConferenceOptions defaultOptions
            = new JitsiMeetConferenceOptions.Builder()
            .setWelcomePageEnabled(true)
            .setServerURL(buildURL(defaultURL))
            .setFeatureFlag("call-integration.enabled", false)
            .setFeatureFlag("resolution", 360)
            .setFeatureFlag("server-url-change.enabled", !configurationByRestrictions)
            .setFeatureFlag("calendar.enabled", false)
            .setFeatureFlag("live-streaming.enabled", false)
            .setFeatureFlag("recording.enabled", false)
            .setFeatureFlag("video-share.enabled", false)           ## <---- video share feature flag
            .setFeatureFlag("invite.enabled", false)
            .setFeatureFlag("close-captions.enabled", false)
            .build();
        JitsiMeet.setDefaultConferenceOptions(defaultOptions);
    }

However, when built, signed and installed on an Android device, the video sharing feature is still available

Expected behavior:

If I disable the video-share feature flag, it should not appear in the Android application anymore.

Actual behavior:

Even if I disabled the video-share feature flag, the button to share a video still appears in the Android application.

Server information:

  • Jitsi Meet version: stable-4857
  • Operating System: debian10

Client information:

  • Browser / app version: android-20.4.1
  • Operating System: Android 10

Additional information:

Screenshot_20200923

Issue Analytics

  • State:closed
  • Created 3 years ago
  • Comments:15 (7 by maintainers)

github_iconTop GitHub Comments

1reaction
moskalandcommented, Feb 25, 2021

@mfts still facing issue on my end: jitsi-meet-sdk:3.1.0" minSdkVersion 24 targetSdkVersion 30 compileSdkVersion 30

1reaction
saghulcommented, Sep 25, 2020

We don’t maintain that package, sorry. Our SDK is released to our maven repo or cocoapods respectively. See here: https://jitsi.github.io/handbook/docs/dev-guide/dev-guide-mobile

Read more comments on GitHub >

github_iconTop Results From Across the Web

A Guide to Getting Started Quickly With Android Feature Flags
When it comes to getting started with feature flags (Android feature ... First, open your build.gradle file (for the module, not the whole ......
Read more >
Are feature flags, build variants, and sample apps related ...
Are feature flags, build variants, and sample apps related concepts? This article focus on Android projects, but the idea can be applied on ......
Read more >
What are Android Feature Flags and how to enable them
The only issues you'll find with Feature Flags is that the names aren't very descriptive (so you'll need to do a bit of...
Read more >
<uses-feature> | Android Developers
Declares a single hardware or software feature that is used by the application. The purpose of a <uses-feature> declaration is to inform any ......
Read more >
Report inappropriate videos, channels and other content on ...
We rely on YouTube community members to report or flag content that they find inappropriate. Reporting content is anonymous, so other users can't...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found