getAll request on '_MANY' association

Describe the bug I want to get ‘_MANY’ association and rest-hapi return all datas of the model of association

To Reproduce Steps to reproduce the behavior:

1. Create ‘_MANY’ association

associations: {
	companies: {
		type: '_MANY',
		alias: 'companies',
		model: 'companies',
	},
},

1. I am creating companies in the model companies

2. I post an id company in my companies association

3. I get the association companies and response contains all the companies whereas in the companies association i have only one company

{
  "docs": [
    {
      "_id": "5d5cae2e3356752c4f2d4414",
      "subsidiaries": [
        {
          "_id": "5d5cae373356752c4f2d4416",
          "subsidiaries": [],
          "name": "string",
          "naf": "string",
          "siret": "string",
          "createdBy": "5d5c9e1a6b233e246ad4f611",
          "createdAt": "2019-08-21T02:36:39.450Z",
          "institutions": []
        }
      ],
      "name": "string",
      "naf": "string",
      "siret": "string",
      "createdBy": "5d5c9e1a6b233e246ad4f611",
      "createdAt": "2019-08-21T02:36:30.548Z",
      "institutions": []
    },
    {
      "_id": "5d5cae373356752c4f2d4416",
      "subsidiaries": [],
      "name": "string",
      "naf": "string",
      "siret": "string",
      "createdBy": "5d5c9e1a6b233e246ad4f611",
      "createdAt": "2019-08-21T02:36:39.450Z",
      "institutions": []
    },
    {
      "_id": "5d5ebd0207b9b804f763dc2a",
      "subsidiaries": [],
      "name": "Hey",
      "naf": "string",
      "siret": "string",
      "createdBy": "5d5db71b1c99220acc90ae45",
      "createdAt": "2019-08-22T16:04:18.189Z",
      "institutions": []
    }
  ],
  "pages": {
    "current": 1,
    "prev": 0,
    "hasPrev": false,
    "next": 2,
    "hasNext": false,
    "total": null
  },
  "items": {
    "begin": null,
    "end": null,
    "total": 3
  }
}

Expected behavior getAll request on ‘_MANY’ association should return only the id’s of the association and not fulld datas of the corresponding model.

Desktop (please complete the following information):

• OS: OSX
• Browser: Chrome
• Version: 76.0.3809.100

Additional context Sorry for my deplorable English, i hope its comprehensive ! Thanks for your answer.

[JKHeadley]

Hi @Clemssss, it’s because you are overriding the query parameter in the middleware function instead of modifying it. getAll internally uses the query parameter to filter the results based on the ownerId. When you override it, you erase the filter and therefore get all of the company documents rather than the docs under the ownerId.

Try changing your middleware to:

	find: {
	  pre: (_id, query, request, Log) => ({
            ...query,
            $embed: ['subsidiaries']
          }),
	},
	list: {
	  pre: (query, request, Log) => ({
            ...query,
            $embed: ['subsidiaries']
          }),
	},

[JKHeadley]

Not at all, its easy to miss!