RestClient PlaceOrder

Describe the bug restClient.Spot.Order.PlaceOrder(“BTCUSDT”, OrderSide.Buy, OrderType.Market, 0.1) returns null. Sometimes it places order and returns null but most of the time null is returned and order is not placed. It does not happen every time, but when some time has passed, it happens. KeepAliveUserStream is working fine.

To Reproduce

WebCallResult<BinancePlacedOrder> result = null;
try
{
    result = restClient.Spot.Order.PlaceOrder("BTCUSDT", OrderSide.Buy, OrderType.Market, 0.1);
    if (result.Success)
    {
         return result.Data.OrderId;
    }
}
catch (Exception ex)
{
    Console.WriteLine(ex.Message); --- Object reference not set to an instance of an object.
}

Expected behavior WebCallResult != null is returned, so Success or Error can be checked

[JKorf]

You’re not checking any result if it was successfull. If you call for example GetAccountInfo you’ll have to check if the call was successful by doing something like this:

var accountInfoResult = client.General.GetAccountInfo();
if(!accountInfoResult.Success)
{
  // Handle error, the accountInfoResult.Error property will have more details on what went wrong
  return;
}

var data = accountInfoResult.Data;

Checking it like this will guarentee that data is never null. If the call fails for some reason then client.General.GetAccountInfo().Data.Balances will throw an exception because the Data property is null.

[ZigmundL]

Very interesting info, thx. It seems to me a little wierd to create a new instance of restclient for every request. I thought that one object would be enough. Like you create a single instance, and use it so send different requests. That is what I was doing. I’m testing your examples with using and multiple restclients at the moment.