question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

addKtlintCheckGitPreCommitHook always successfully even i broke the rule [pre-commit]

See original GitHub issue

when using addKtlintCheckGitPreCommitHook, my changed_files with broken rule still got successfully then use addKtlintFormatGitPreCommitHook facing still same issues this is my build gradle on project level

buildscript {
    repositories {
        maven { url "https://plugins.gradle.org/m2/" }
 }

dependecies {
        classpath "org.jlleitschuh.gradle:ktlint-gradle:9.2.1"
 }
}
allprojects {
    apply plugin: "org.jlleitschuh.gradle.ktlint"
 ktlint {
        version = "0.35.0"
        debug = true
        verbose = true
        android = true
        outputToConsole = true
        outputColorName = "RED"
        enableExperimentalRules = false
    }
}

when using ktlintCheck my changed_files ignored.

is that any problem with your PinternalKtlintGitFilter ?

Issue Analytics

  • State:closed
  • Created 3 years ago
  • Comments:15 (1 by maintainers)

github_iconTop GitHub Comments

2reactions
JLLeitschuhcommented, May 3, 2022
0reactions
edwardmpcommented, May 3, 2022

Issue is actually already described in #562 and fixing PR is merged. However this is not released yet.

Read more comments on GitHub >

github_iconTop Results From Across the Web

black as pre-commit hook always fails my commits
We ask black to prevent any commits that include python files that haven't been formatted properly by black. It still makes sure that...
Read more >
ktlint-gradle - Bountysource
BUILD SUCCESSFUL in 5s 7 actionable tasks: 7 executed ... folder- addKtlintCheckGitPreCommitHook always successfully even i broke the rule [pre-commit] $ 0.
Read more >
Supported hooks - pre-commit
name-tests-test - verifies that test files are named correctly. no-commit-to-branch - don't commit to branch; requirements-txt-fixer - sorts entries in ...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found