write_url produces broken hyperlink

Hi,

I am using XlsxWriter to create an report file with links to problems in other excel documents. Everything worked great, until i realized that some hyperlinks didn’t work when there was a space in the name of a worksheet.

I am using Python version 3.4 and XlsxWriter 0.8.5 (freshly pulled from github) and Excel version 2013.

Here is some code that demonstrates the problem:

import xlsxwriter

filename = 'test.xlsx'

wb = xlsxwriter.Workbook(filename)

ws = wb.add_worksheet('other_sheet')
wb.add_worksheet('test sheet')

# normally one would use an internal link here, but for this demonstration i need an external link:
ws.write_url(0, 0, "external:{}#'test sheet'!A1".format(filename))  
wb.close()

I’ve already found the problem: External links are escaped test.xlsx#test sheet!A1 becomes test.xlsx#test%20sheet!A1 which doesn’t work. Excel 2013 would like to have test.xlsx#'test sheet'!A1.

[jmcnamara]

Fixed in version 0.8.6: http://xlsxwriter.readthedocs.io/changes.html

[816-8055]

Thank you very much! That’s what I’d call a quick fix!