Rounding

One oddity to me is the rounding. While I can understand that

humanize.naturaltime(2*365*24*60*60 - 1)

is 1 year, 11 months ago and not 2 years ago, because the year is not complete yet and we don’t celebrate birthdays early (“how long ago was it?” - “2 years?” - “not yet!”), my intuitive expectation of

humanize.naturaldelta(2*365*24*60*60 - 1)

is actually 2 years - because with deltas (“how long did it take?”), I feel rounding is much more natural.

So for 101_943 / 1_000_000, I’d probably expect 102 milliseconds.

_Originally posted by @bersbersbers in https://github.com/jmoiron/humanize/issues/75#issuecomment-659220243_

[bersbersbers]

That does help, thanks. A few tests that I did revealed these unexpected ones:

>>> humanize.naturaldelta(2*365*24*60*60-1)
'2 years'
>>> humanize.naturaldelta(1*365*24*60*60-1)
'1 year, 364 days'

I did not test further as it seems an error needs to be fixed first.

[hugovk]

🚀 Development has moved to https://github.com/python-humanize/humanize 🚀

Please open new issues at https://github.com/python-humanize/humanize/issues