inefficient use of loggers

Issue #1672 drew my attention to inefficient use of loggers in JMonkeyEngine. A quick scan found dozens of instances that can probably be improved. A common anti-pattern is code that constructs a log message using string concatenation, as in GltfUtilities:

                logger.log(Level.WARNING, "Unsupported Vertex Buffer type " + attribute);

Most of these should be refactored.

[pspeed42]

WARNING is a bad example because it is almost always enabled and so the check is redundant.

Whatever crappy-JUL’s version of INFO is… that’s sort of on the fence. Finer than that should either be gated or use the pattern version. (I prefer gating in general if a conversion is being done because that pattern idiom has an argument limit before it’s no better than concatenating a string.)

[vxel]

Oh yes it is.

Btw, I now understand the point of @pspeed42 regarding the personal style. If the statement is already gated, then the difference between

logger.log(Level.FINE, "{0} {1}", new Object[]{myobject1, myobject2}) and logger.log(Level.FINE, myobject1 + " " + myobject2)

is mostly aesthetic.