Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.
And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.
Performance: LightFilter gets applied even if not needed
See original GitHub issueHi, during my investigation on my deferred performance i found that the LightFilter gets applied on each RenderManager.renderGeometry()
I looked up on how Jme internally works around this issue when no lights are needed and it seems it does not.
It surely impacts the performance of the AbstractShadowRenderer. At least on objects outside of the view frustum but inside of the shadow frustum the light filtering is not needed.
A quick fix would be to implement:
tmp = RenderManager.getLightFilter(); RenderManager.setLightFilter(null); //Do your stuff RenderManager.setLightFilter(tmp);
what do you think? applying the easy fix or implement a fix at global scale?
Issue Analytics
- State:
- Created 10 months ago
- Comments:20 (20 by maintainers)
Top Results From Across the Web
Top Related Medium Post
Top Related StackOverflow Question
Troubleshoot Live Code
Top Related Reddit Thread
Top Related Hackernoon Post
Top Related Tweet
Top Related Dev.to Post
Top Related Hashnode Post
This is why I was curious what revert() was doing… because I couldn’t see how it would work without sharing state with the entire JVM. …a big no-no.
If it’s user-code that is calling apply/revert then it could just be on an instance instead of a static method… then you can have as many states as you want.
We’ve got some really nasty shared state issues in the anim package that are very tricky to unwind at this point, so I’m very sensitive to this subject.