Please change comments in code as they enter the copyright realm!
See original GitHub issueWe’re building a project with Webpack we use Terser (newer uglyjs lib) to compress all javascript. Terser extracts all copyright info and put it nicely in a copyright file so the copyright info doesn’t get lost and is for willingly to read.
This works fine for all libs we use as they all have their copyright information behind comments starting with /*!
.
However, pixi3d is using the same prefix for a whole bunch of comments in the javascript, resulting all kinds of junk being included in the copyright file now, so users see this in the copyright file, coming from pixi3d, which is obviouly not copyright information:
You might understand we don’t like this and want to ask you if you could replace these ‘copyright’-prefixes with normal comment prefixes, like /
or /*
. On the other hand you could also add your copyright information in there WITH the given ‘copyright’ (/*!
) prefix so it gets included in there.
For you this would probably mean 5 minutes of work, but for us it’s basically impossible to strip it out as it’s all being done automatically by terser on each webpack build.
Could you please change these comment prefixes?
Thanks in advance!
Issue Analytics
- State:
- Created a year ago
- Comments:5 (2 by maintainers)
Top GitHub Comments
@jnsmalm Just compiled with the new pixi3d version and can confirm all comments are gone. Thanks!
Found a Webpack setting which could remove these comments, will be fixed in next release.