question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Please change comments in code as they enter the copyright realm!

See original GitHub issue

We’re building a project with Webpack we use Terser (newer uglyjs lib) to compress all javascript. Terser extracts all copyright info and put it nicely in a copyright file so the copyright info doesn’t get lost and is for willingly to read.

This works fine for all libs we use as they all have their copyright information behind comments starting with /*!.

However, pixi3d is using the same prefix for a whole bunch of comments in the javascript, resulting all kinds of junk being included in the copyright file now, so users see this in the copyright file, coming from pixi3d, which is obviouly not copyright information: image

You might understand we don’t like this and want to ask you if you could replace these ‘copyright’-prefixes with normal comment prefixes, like / or /*. On the other hand you could also add your copyright information in there WITH the given ‘copyright’ (/*! ) prefix so it gets included in there. For you this would probably mean 5 minutes of work, but for us it’s basically impossible to strip it out as it’s all being done automatically by terser on each webpack build.

Could you please change these comment prefixes?

Thanks in advance!

Issue Analytics

  • State:closed
  • Created a year ago
  • Comments:5 (2 by maintainers)

github_iconTop GitHub Comments

1reaction
Frikselcommented, May 7, 2022

@jnsmalm Just compiled with the new pixi3d version and can confirm all comments are gone. Thanks!

1reaction
jnsmalmcommented, Apr 30, 2022

Found a Webpack setting which could remove these comments, will be fixed in next release.

Read more comments on GitHub >

github_iconTop Results From Across the Web

ORA-01034: ORACLE NOT AVAILABLE - Ask TOM
connect system password : password. i got following errors. ORA-01034: ORACLE NOT AVAILABLE ORA-27101: shared memory realm does not exist ...
Read more >
U.S. Copyright Office Fair Use Index
The goal of the Index is to make the principles and application of fair use more accessible and understandable to the public by...
Read more >
Code Review: Please Remove Comments From Your Code
The reason why I ask to remove most of the comments during code review ... He changed 5 to 10 and updated the...
Read more >
License to Copy: Your Software Code Isn't Safe After Google v ...
My point is that one cannot reach Fair Use IF copyright has not attached. Fair Use – as a legal concept – has...
Read more >
Commenting on a pull request - GitHub Docs
Under your repository name, click Pull requests. ... On the pull request, click Files changed. ... Hover over the line of code where...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found