Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

possibly a bug in PullRequest #139 (N-best candidates)?

See original GitHub issue

Hi @sjarmero,

After your pull request #139 has been merged, I’ve got an error at https://github.com/joeynmt/joeynmt/blob/eb29133ec8662c9d9520d6a72b8888d84a90cc80/joeynmt/prediction.py#L114

It should look like this, maybe?

assert len(sort_reverse_index) == batch.nseqs

and a small problem here, too.

https://github.com/joeynmt/joeynmt/blob/eb29133ec8662c9d9520d6a72b8888d84a90cc80/joeynmt/prediction.py#L131-L136

because now you use append, not extend as before, valid_attention_scores wil become non-empty even if attention_scores is None, and it unexpectedly triggers this if-block:

https://github.com/joeynmt/joeynmt/blob/eb29133ec8662c9d9520d6a72b8888d84a90cc80/joeynmt/prediction.py#L355-L364

thank you for your effort to include the nbest list!

@juliakreutzer, FYI

Issue Analytics

State:
Created 3 years ago
Comments:5 (1 by maintainers)

Top GitHub Comments

2reactions

sjarmerocommented, Apr 9, 2021

Hi @aitorme That line has been corrected in Pull Request https://github.com/joeynmt/joeynmt/pull/145, which has not been merged yet

1reaction

juliakreutzercommented, Apr 9, 2021

Fine with me! I’ll do that.

Top Results From Across the Web

plot throws ambiguity error · Issue #139 · MakieOrg/Makie.jl · GitHub

julia> using Makie julia> plot(1.0:5,randn(5)) ERROR: MethodError: AbstractPlotting.plot!(::Combined{Any,Tuple{StepRangeLen{Float64,Base.

Error Codes | Yarn - Package Manager

A list of Yarn's error codes with detailed explanations.

Identifying Redundancies in Fork-based Development

Although one pull request mentioned the bug number, it is hard to tell whether these two pull requests are solving the same problem...

Duplicate Pull Request Detection: When Time Matters - Xin Xia

Ranking approaches: [3, 6, 7, 13, 14, 21, 28, 31–34, 39,. 42],they use a bug report as input and output a ranked list...

Does code quality affect pull request acceptance? An ...

To the best of our knowledge, no studies have investigated if quality flaws such as code smells, anti-patterns, or coding style violations affecting...